Skip to content

test(app-shell,scripts): @object-ui/i18n joins COVERED_SPECIFIERS (objectui#7337) - #7920

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-7337-i18n-covered-specifier-flip
Sep 6, 2026
Merged

test(app-shell,scripts): @object-ui/i18n joins COVERED_SPECIFIERS (objectui#7337)#7920
baozhoutao merged 1 commit into
mainfrom
claude/issue-7337-i18n-covered-specifier-flip

Conversation

@claude

@claude claude Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Fixes #7337

The ruled follow-up (option A) to PR #7889: the @object-ui/i18n slice of the
check-vi-mock-inherit ratchet is finished, so the gate — not a pin file — now
holds that specifier's frozen population at zero.

Three steps, one PR, in the only order that works. Converting first and flipping
second is not stylistic: with a frozen factory still in the tree the flip fails
check:vi-mock-inherit on the very next run.

  1. packages/app-shell/src/views/__tests__/DeclaredActionsBar.test.tsx — the one
    remaining frozen vi.mock('@object-ui/i18n', ...) factory obtains the real
    module and spreads it, keeping the three overrides the suite needs
    (useObjectLabel, useObjectTranslation, pickLocalized). Same spelling as
    its already-converted sibling DeclaredActionsBar.overrideAffordance.test.tsx.
  2. scripts/__tests__/check-vi-mock-inherit.test.ts — the case that recorded WHY
    the specifier was not covered yet is deleted, along with the two expectations
    that encoded the un-flipped state (the held-file carve-out, and a census
    expectation that allowed one non-inheriting site).
  3. scripts/check-vi-mock-inherit.mjs@object-ui/i18n joins
    COVERED_SPECIFIERS, and the header stops saying the covered set has exactly
    one member.

Measured, before and after, on this branch

reading before (84ce0b80d) after (4c871b0e3)
@object-ui/i18n judged call sites 92 92
... inheriting 91 92
... frozen 1 0
... unreadable 0 0
all 39 workspace specifiers: frozen 315 314
all 39 workspace specifiers: inheriting 315 316

The one frozen site before was DeclaredActionsBar.test.tsx:65, exactly as the
release comment predicted. Zero sites moved the other way: the frozen sets
were diffed per site (file plus mocked specifier, line deliberately omitted
because an edit above a site shifts its line without moving its verdict), and the
only difference is that one site leaving.

Note for whoever re-derives these: the all-specifier population here is taken over
all 39 @object-ui/* workspace packages, read out of packages/*/package.json.
The last reading on the merged head used a 21-specifier set and reported 312
frozen / 627 covered. The delta is entirely definitional — inherits agrees at
315 in both — so the extra 3 are frozen sites on specifiers the narrower set never
named, not a change in the tree.

Gate verdict line after the flip:

check-vi-mock-inherit: OK (4331 tracked source file(s), 2610 test-named; 586 carry
a mock; 223 call site(s) on @object-ui/react, @object-ui/i18n judged (223 inherit,
0 auto-mocked); 409 other workspace, 229 external, 844 local, 0 non-static, 3
embedded in a string literal -- all out of scope).

223 = 131 on @object-ui/react plus 92 on @object-ui/i18n.

Reverse verification, two legs

Both legs: commit first, mutate, prove the bytes reached disk by counting the
injected and the deleted text, run, restore with git checkout HEAD -- PATH,
prove the restore by an empty git diff HEAD and a blob hash equal to HEAD's.
Restore runs from a trap on EXIT/INT/TERM with absolute paths.

Leg A — re-freeze the factory, keep the flip. The gate goes RED, exit 1,
naming the site:

- packages/app-shell/src/views/__tests__/DeclaredActionsBar.test.tsx:65 -- vi.mock("@object-ui/i18n")
  the factory never obtains the real module

Restored blob 67cdf539b, git diff HEAD empty.

Leg B — drop the specifier from the covered set, keep the conversion. This is
the non-vacuity check for the one case this PR ADDS, and it measures the exact
failure mode that case exists for: the gate stays GREEN (exit 0, 131 judged
instead of 223) because every @object-ui/i18n call site becomes unjudged — a
ratchet retiring in silence. The pin file is what reddens, with exactly one
failing case, the new one:

FAIL scripts/__tests__/check-vi-mock-inherit.test.ts > the sweep ... > the specifier IS in COVERED_SPECIFIERS
AssertionError: the sweep landed; removing the specifier retires the ratchet silently:
expected [ '@object-ui/react' ] to include '@object-ui/i18n'
Tests  1 failed | 68 passed (69)

Restored blob 1cea0ddf4, git diff HEAD empty.

One case changed beyond the three steps, and why

puts the census in the verdict built its expected string from a file-local
constant naming a single specifier, while the gate's verdict line joins the whole
covered set. It read as an assertion about the verdict line and was really an
assertion about the set's SIZE — measured: it was the only failure on the first
run after the flip. It now derives the names from COVERED_SPECIFIERS itself, so
the next widening does not pay for it. The rest of the death pin (legs 1/2/3, the
non-vacuity control, the replay case and the JSON-reporter verdicts) is untouched:
69 cases before, 69 after.

Gates, each with its own printed verdict

Exit codes captured by redirect-then-capture, never through a pipe.

gate exit verdict
check:vi-mock-inherit 0 OK ... 223 call site(s) ... judged (223 inherit, 0 auto-mocked)
check:vi-mock-specifiers 0 OK (4331 tracked source file(s) ... 844 relative specifier(s) resolved
pnpm exec vitest run scripts/__tests__/check-vi-mock-inherit.test.ts 0 Test Files 1 passed (1) · Tests 69 passed (69)
pnpm exec vitest run scripts/__tests__/ 0 Test Files 107 passed (107) · Tests 3220 passed (3220)
pnpm exec vitest run packages/app-shell/src/views/__tests__/DeclaredActionsBar.test.tsx 0 Test Files 1 passed (1) · Tests 33 passed (33)
pnpm type-check:scripts 0 clean; --listFiles names the pin file exactly once
pnpm --filter @object-ui/app-shell type-check 0 both halves; tsconfig.test.json --listFiles names the converted file once
pnpm check:control-bytes 0 OK (scanned 6396 tracked text file(s); skipped 85 binary)
pnpm lint:root 0 0 errors, 33 warnings (all pre-existing)
pnpm exec eslint . 0 full farm, not narrowed — 4329 files, 0 errors
pnpm lint:coverage 0 46/46 packages linted, 0 with outstanding errors
pnpm check:unreferenced-sources 0 Every shipped source file in every covered package is reachable
node scripts/check-changeset-presence.mjs 0 1 released-package source file changed, 1 changeset, EMPTY frontmatter
pnpm changeset:check 0 fixed group OK, no major
node scripts/check-governed-queue-guard.mjs --test 0 NOT GOVERNED — 4 paths, none matched

Every heavy run went through scripts/pm/os-verify-lock.sh; verdicts read from its
VERDICT command-exit line, never a bare shell status. The dependency closure was
built first (pnpm --filter '@object-ui/app-shell^...' build) — without it
type-check fails on missing sibling declaration files, which reads exactly like
a break this diff caused.

Union re-run at the final commit 4c871b0e3, working tree clean.

Scope

Four files: the converted test, the pin file, the gate, and one
empty-frontmatter changeset. No other specifier is swept — objectui#6892 stays
serial behind this card. No exemption table and no per-site allowlist; the pin
that forbids one still passes.

Part of the worklist tracked in objectui#6892. Related: PR #7889, PR #7846.


Generated by Claude Code

… (objectui#7337)

The last frozen `vi.mock('@object-ui/i18n', …)` factory in the tree —
`DeclaredActionsBar.test.tsx` — now obtains the real module and spreads it, so
the specifier's frozen population is zero and it joins the gate's covered set in
the same PR, which is what the gate's own header requires of a widening.

Three steps, in the only order that works: converting first, then flipping.
Flipping while a frozen factory remains fails `check:vi-mock-inherit` on the
very next run.

Measured on this branch, before -> after: `@object-ui/i18n` 92 judged / 91
inherit / 1 frozen -> 92 judged / 92 inherit / 0 frozen; across all 39 workspace
specifiers 315 -> 314 frozen with zero sites moving the other way. The gate's
verdict line now reads 223 call sites judged (131 + 92), all inheriting.

The pin file loses the case that recorded WHY the specifier was not covered yet
and gains its positive half: dropping a member of the covered set makes every
call site on it unjudged, so the gate would stay green over a population it no
longer looks at. One census case that spelled a single specifier was really
asserting the SET'S SIZE, and is now derived from `COVERED_SPECIFIERS` itself.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013uAaxiwgYDybsTNV9xwa1M
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 50 chunks) 3187.4 KB 3191.4 KB
Main entry chunk (gzip) 143.5 KB 350 KB
Entry file index-DTVrS7Iy.js
Status PASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 15.67KB 5.75KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 25.05KB 9.16KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.46KB 3.43KB
auth (index.js) 3.19KB 1.44KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 5.13KB 2.35KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 510.60KB 116.20KB
core (index.js) 6.96KB 2.79KB
create-plugin (index.js) 10.08KB 3.26KB
data-objectstack (index.js) 182.08KB 50.62KB
fields (index.js) 242.44KB 61.25KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 4.28KB 1.75KB
i18n (index.js) 3.65KB 1.47KB
i18n (pickLocalized.js) 7.62KB 3.26KB
i18n (provider.js) 26.89KB 9.04KB
i18n (useDisplayLocale.js) 2.85KB 1.45KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 38.98KB 10.98KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 4.39KB 1.66KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 11.71KB 4.29KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 5.12KB 1.74KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 15.75KB 3.80KB
plugin-calendar (index.js) 47.87KB 13.31KB
plugin-charts (index.js) 70.92KB 19.75KB
plugin-chatbot (index.js) 196.19KB 46.37KB
plugin-dashboard (index.js) 132.88KB 34.69KB
plugin-designer (index.js) 212.86KB 43.19KB
plugin-detail (index.js) 250.55KB 64.06KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 132.87KB 32.66KB
plugin-gantt (index.js) 167.26KB 41.00KB
plugin-grid (index.js) 209.29KB 56.78KB
plugin-kanban (index.js) 52.71KB 14.55KB
plugin-list (index.js) 113.76KB 27.75KB
plugin-map (index.js) 20.44KB 6.78KB
plugin-markdown (index.js) 13.93KB 4.81KB
plugin-report (index.js) 43.59KB 11.97KB
plugin-timeline (index.js) 30.40KB 8.76KB
plugin-tree (index.js) 9.20KB 3.19KB
plugin-view (index.js) 85.24KB 20.94KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 81.07KB 26.86KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.63KB 2.18KB
react (schema-input.js) 2.32KB 1.24KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (codegen.js) 5.41KB 2.34KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 4.93KB 2.24KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 20.57KB 5.88KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 10.35KB 3.60KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.74KB 1.41KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 4.73KB 2.28KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants